It looks good to me. Trying to unify all the query infos has proved to be difficult with the different struct types, parameters and code being done in each. So I guess having another func is ok. We could have a func just doing a switch on all 3 funcs, as a first follow up cleanup. Some notes: - Probably needs more thorough checks on buffer sizes - UID-mapping is still TODO (also in my query dir code) and probably breaks with multi user mounts Steve French <smfrench@xxxxxxxxx> writes: > @@ -595,6 +596,62 @@ static int cifs_sfu_mode(struct cifs_fattr *fattr, const unsigned char *path, > #endif > } > > + /* The srv fs device id is overridden on network mount so setting rdev isn't needed here */ > +/* fattr->cf_rdev = le32_to_cpu(info->DeviceId); */ Indentation. Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx> Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
