Aurélien, Implemented your suggestion. Sent v3 for the same. On Thu, Jun 4, 2020 at 10:51 PM Aurélien Aptel <aaptel@xxxxxxxx> wrote: > > Kenneth D'souza <kdsouza@xxxxxxxxxx> writes: > > Currently the end user is unaware with what sec type the > > cifs share is mounted if no sec=<type> option is parsed. > > With this patch one can easily check from DebugData. > > LGTM but I would move the security_types next to the enum definition in > cifsglob.h somehow, so that it will be harder to forget to update one if > the other changes. > > Since it is in a header, maybe via an inline func with a > switch... simple but more verbose. Or X-macros [1] magic (might be > overkill). > > 1: https://www.geeksforgeeks.org/x-macros-in-c/ > > Cheers, > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München) >
