Did you also test (at least briefly) with vers=1.0 since some of your code affects that code path too? And if anyone figures out how to configure an x86_64 Linux to use PAGE_SIZE of 64K or larger let me know... On Sun, Apr 12, 2020 at 9:24 PM Jones Syue via samba-technical <samba-technical@xxxxxxxxxxxxxxx> wrote: > > Hello Pavel > > Thanks for kindly reviewing! > Please find the attached v2.patch. > > -- > Regards, > Jones Syue | 薛懷宗 > QNAP Systems, Inc. > > > On Sat, Apr 11, 2020 at 2:25 AM Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > > > > Hi Jones, > > > > Thanks for the patch! > > > > It will work although it is probably a little bit cleaner to > > initialize server->max_read to server->maxBuf for SMB1 and use the > > server->max_read in the readpages condition check instead. > > > > @Others, thoughts? > > > > -- > > Best regards, > > Pavel Shilovsky -- Thanks, Steve
