Looks good, thanks! Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx> -- Best regards, Pavel Shilovsky вс, 12 апр. 2020 г. в 19:23, Jones Syue <jonessyue@xxxxxxxx>: > > Hello Pavel > > Thanks for kindly reviewing! > Please find the attached v2.patch. > > -- > Regards, > Jones Syue | 薛懷宗 > QNAP Systems, Inc. > > > On Sat, Apr 11, 2020 at 2:25 AM Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > > > > Hi Jones, > > > > Thanks for the patch! > > > > It will work although it is probably a little bit cleaner to > > initialize server->max_read to server->maxBuf for SMB1 and use the > > server->max_read in the readpages condition check instead. > > > > @Others, thoughts? > > > > -- > > Best regards, > > Pavel Shilovsky