This LGTM but I think we should really test it on the buildbot. Especially DFS failover and multichannel. Stefan Metzmacher <metze@xxxxxxxxx> writes: > +int > +cifs_connect_session_locked(const unsigned int xid, > + struct cifs_ses *ses, > + struct nls_table *nls_info, > + bool retry) > +{ > + int rc; > + > + if (ses->server->tcpStatus == CifsNeedReconnect) { > + return -EHOSTDOWN; > + } This check is now done everytime. Probably it's correct, but worth pointing out. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)