Stefan Metzmacher <metze@xxxxxxxxx> writes: > The first patches consolidate the retry/reconnect handling between SMB1 > and SMB2/3. This code is very tricky, we had to tweak it multiple times to deal with races, deadlocks and DFS (with DFS we have to failover to a different server and have to update TCP_Server_Info fields) and we can't test/repro those easily so we need to be very careful. I will start looking but it will take some time. In any case amazing work in unifying these things, reconnect code path is horribly complex. Also, you should try to run checkpatch.pl (from the kernel repo) and sparse (kernel static analysis). You need a recent version of sparse to work on the kernel (get&build the git repo somewhere). I like to use something this when working on a series: git rebase -x 'bash -c "./scripts/checkpatch.pl <(git format-patch -1 --stdout)" && touch fs/cifs/*.[ch] && make CHECK=path_to_your_sparse_bin C=1' HEAD~13 (on one line) Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
