On Mon, Feb 10, 2020 at 5:31 AM L Walsh <cifs@xxxxxxxxx> wrote: > > On 2020/02/06 04:29, Steve French wrote: > > A commonly used SMB3 feature is change notification, allowing an > > app to be notified about changes to a directory. The SMB3 > > Notify request blocks until the server detects a change to that > > directory or its contents that matches the completion flags > > that were passed in and the "watch_tree" flag (which indicates > > whether subdirectories under this directory should be also > > included). See MS-SMB2 2.2.35 for additional detail. > > > ---- > How does the SMB3 feature "change notification" differ from > the SMB2 feature described in MS-SMB2 2.2.35? > > Isn't it more typical to describe features by the spec version > that they were first publish under -- especially since the doc > describing the feature is under the SMB2 documents? > > By calling it a SMB3 feature, does that mean you are removing > it from SMB2? That is a good question. I should have made more clear that although many servers support Change Notify prior to SMB3 dialect, we chose to implement it in SMB3 (late 2012 and later dialect) to minimize testing risks and since we want to encourage users to use SMB3 or later (or at least SMB2.1 or later since security is significantly better for later dialects than for SMB1 and even SMB2) Change Notify is available in all dialects (SMB2, SMB2.1, SMB3, SMB3.1.1) for many servers but for the client we just implemented it for SMB3 and later. If you have a server that you want to support that requires SMB2 or SMB2.1 mounts, I wouldn't mind a patch to add notify support for those older dialects but I would like to encourage use of SMB3 or later (or at least SMB2.1 or later) where possible. Steve