Reviewed-By: Ronnie Sahlberg <lsahlber@xxxxxxxxxx> But drop the extra parenthesises here : + (2 * sizeof(struct cifs_ace)); ----- Original Message ----- From: "Steve French" <smfrench@xxxxxxxxx> To: "CIFS" <linux-cifs@xxxxxxxxxxxxxxx> Sent: Friday, 17 January, 2020 12:28:03 PM Subject: [PATCH][SMB3] Fix modefromsid newly created files to allow more permission on server When mounting with "modefromsid" mount parm most servers will require that some default permissions are given to users in the ACL on newly created files, and for files created with the new 'sd context' - when passing in an sd context on create, permissions are not inherited from the parent directory, so in addition to the ACE with the special SID (which contains the mode), we also must pass in an ACE allowing users to access the file (GENERIC_ALL for authenticated users seemed like a reasonable default, although later we could allow a mount option or config switch to make it GENERIC_ALL for EVERYONE special sid). -- Thanks, Steve