Re: [PATCH 2/2] smbinfo: rewrite in python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



чт, 12 дек. 2019 г. в 16:33, Pavel Shilovsky <piastryyy@xxxxxxxxx>:
>
...
>
> I am planning to merge this for the next after next release since it
> doesn't add new functionality but also bring some risk. So, we will
> have time to catch possible regressions here.

Tentatively merged:

https://github.com/piastry/cifs-utils/commit/b7bd342c6d4dc794dd29760d1417e8a87849b531

Btw, I noticed differences between the current smbinfo help output:

$ smbinfo
Usage: smbinfo [-v] [-V] <command> <file>
Try 'smbinfo -h' for more information.

and the new one:

$ ./smbinfo
usage: smbinfo [-h] [-V]
               {fileaccessinfo,filealigninfo,fileallinfo,filebasicinfo,fileeainfo,filefsfullsizeinfo,fileinternalinfo,filemodeinfo,filepositioninfo,filestandardinfo,fsctl-getobjid,getcompression,setcompression,list-snapshots,quota,secdesc,keys}
               ...
smbinfo: error: the following arguments are required: subcommand


We should probably keep the output the same if possible. I personally
like the original version better because it is shorter - for more
details the user may type smbinfo -h to get the list of supported
commands. But no strong opinion here.

--
Best regards,
Pavel Shilovsky




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux