Hi, Tom Talpey <ttalpey@xxxxxxxxxxxxx> writes: > Sorting by speed is definitely appropriate, but sorting the other > multichannel attributes is just as important. For example, if the > RDMA attribute is set, the address should actually be excluded > for non-RDMA connections (a second, non-RDMA entry is included, > if the interface supports both). And, the RSS attribute indicates a > "better" destination than non-RSS for a given speed, because it is > more efficient at local traffic management. Note that the way the list is used has been altered in a later patch here: https://lore.kernel.org/linux-cifs/20191120161559.30295-2-aaptel@xxxxxxxx/T/#u Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)