tags added - tentatively merged into cifs-2.6.git for-next pending testing (buildbot) On Mon, Nov 25, 2019 at 5:41 AM Aurélien Aptel <aaptel@xxxxxxxx> wrote: > > "Paulo Alcantara (SUSE)" <pc@xxxxxx> writes: > > We used to skip reconnects on all SMB2_IOCTL commands due to SMB3+ > > FSCTL_VALIDATE_NEGOTIATE_INFO - which made sense since we're still > > establishing a SMB session. > > > > However, when refresh_cache_worker() calls smb2_get_dfs_refer() and > > we're under reconnect, SMB2_ioctl() will not be able to get a proper > > status error (e.g. -EHOSTDOWN in case we failed to reconnect) but an > > -EAGAIN from cifs_send_recv() thus looping forever in > > refresh_cache_worker(). > > > I think we can add a Fixes tag: > > Fixes: e99c63e4d86d ("SMB3: Fix deadlock in validate negotiate hits reconnect") > > Otherwise looks good. > > Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx> > > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München) -- Thanks, Steve