"Paulo Alcantara (SUSE)" <pc@xxxxxx> writes:
> This patch does a couple of things:
>
> - Do some renaming in static code (cosmetic)
> - Use rwlock for cache list
> - Use spinlock for volume list
> - Avoid lock contention in some places
There is too much going on here for a proper review but nothing major
caught my eye (cosmetic should have been separate imo).
> - ce = find_cache_entry(path, &h);
> - if (IS_ERR(ce)) {
> - cifs_dbg(FYI, "%s: cache miss\n", __func__);
> - /*
> - * If @noreq is set, no requests will be sent to the server for
> - * either updating or getting a new DFS referral.
> - */
> - if (noreq)
> - return ce;
> - /*
> - * No cache entry was found, so check for valid parameters that
> - * will be required to get a new DFS referral and then create a
> - * new cache entry.
> - */
I think we should keep comments.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
