пн, 14 окт. 2019 г. в 00:18, Chuhong Yuan <hslester96@xxxxxxxxx>:
>
> cifs_setattr_nounix has two paths which miss free operations
> for xid and fullpath.
> Use goto cifs_setattr_exit like other paths to fix them.
>
> Fixes: aa081859b10c ("cifs: flush before set-info if we have writeable handles")
> Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
> ---
> fs/cifs/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
> index 5dcc95b38310..df9377828e2f 100644
> --- a/fs/cifs/inode.c
> +++ b/fs/cifs/inode.c
> @@ -2475,9 +2475,9 @@ cifs_setattr_nounix(struct dentry *direntry, struct iattr *attrs)
> rc = tcon->ses->server->ops->flush(xid, tcon, &wfile->fid);
> cifsFileInfo_put(wfile);
> if (rc)
> - return rc;
> + goto cifs_setattr_exit;
> } else if (rc != -EBADF)
> - return rc;
> + goto cifs_setattr_exit;
> else
> rc = 0;
> }
> --
> 2.20.1
>
Looks good, thanks.
Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx>
The original patch was tagged for stable, so, it seems that this one
should be tagged too.
--
Best regards,
Pavel Shilovsky
