Can you try the new updated patch? Some of the suggested changes have been incorporated. Pavel picked up the new changes from my github repo. https://github.com/piastry/cifs-utils/commits/next I will send a follow-on patch to work on the remaining changes. On Wed, Oct 9, 2019 at 6:43 PM Aurélien Aptel <aaptel@xxxxxxxx> wrote: > > > We now have 2 user scripts in the repo but the configure script doesn't > know about them: they are not installed. If they are considered dev > tools or experimental that's fine otherwise we should consider > installing them on make install. I just wanted to point this out. > > A bit late but some comments on the script. > > Kenneth D'souza <kdsouza@xxxxxxxxxx> writes: > > +#!/usr/bin/env python > > We should script for python3 at this point I think. Python2 is on the > way out. > > > +def usage(): > > + print("Usage: %s [-h] <options> <filename>" % sys.argv[0]) > > + print("Try 'smb2quota -h' for more information") > > + sys.exit() > > argparse already generates usage message from its conf. > > > + > > +def parser_check(path, flag): > > + titleused = "Amount Used" > > + titlelim = "Quota Limit" > > + titlethr = "Warning Level" > > + titlesid = "SID" > > + buf = array.array('B', [0] * 16384) > > + struct.pack_into('<I', buf, 0, 4) # InfoType: Quota > > + struct.pack_into('<I', buf, 16, 16384) # InputBufferLength > > + struct.pack_into('<I', buf, 20, 16) # OutputBufferLength > > + struct.pack_into('b', buf, 24, 0) # return single > > + struct.pack_into('b', buf, 25, 1) # return single > > + try: > > + f = os.open(path, os.O_RDONLY) > > + fcntl.ioctl(f, CIFS_QUERY_INFO, buf, 1) > > + os.close(f) > > + if flag == 0: > > + print(BBOLD + " %-7s | %-7s | %-7s | %s " + ENDC) % (titleused, titlelim, titlethr, titlesid) > > + q = Quota(buf[24:24 + struct.unpack_from('<I', buf, 16)[0]], flag) > > + print(q) > > + except IOError as reason: > > + print("ioctl failed: %s" % reason) > > + except OSError as reason: > > + print("ioctl failed: %s" % reason) > > + > > + > > +def main(): > > + if len(sys.argv) < 2: > > + usage() > > + > > + parser = argparse.ArgumentParser(description="Please specify an action to perform.", prog="smb2quota") > > description is used to generate a useful help/usage message. Maybe use > "tool to display quota information for the Linux SMB client file system (CIFS)" > > > + parser.add_argument("-tabular", "-t", metavar="", help="Print quota information in tabular format") > > + parser.add_argument("-csv", "-c", metavar="", help="Print quota information in csv format") > > + parser.add_argument("-list", "-l", metavar="", help="Print quota information in list format") > > * I think we should use 2 dashes (i.e. "--tabular") for long options. > * For boolean flags, action="store_true" is what you want > * You can put let argparse know about the path arg, and then use args.path > > parser.add_argument("--tabular", "-t", action="store_true", help="Print quota information in tabular format") > parser.add_argument("--csv", "-c", action="store_true", help="Print quota information in csv format") > parser.add_argument("--list", "-l", action="store_true", help="Print quota information in list format") > parser.add_argument("path", help="Path to query") > > Cheers, > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
