Re: [PATCH][CIFS] simplify code by removing CONFIG_CIFS_ACL ifdef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 24, 2019 at 01:47:16AM -0500, Steve French wrote:
> SMB3 ACL support is needed for many use cases now and should not be
> ifdeffed out, even for SMB1 (CIFS).  Remove the CONFIG_CIFS_ACL
> ifdef so ACL support is always built into cifs.ko
> 
> Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>

This patch results in:

cifs/cifsacl.c:36:15: error: variable 'cifs_idmap_key_acl' has initializer but incomplete type
 static struct key_acl cifs_idmap_key_acl = {
               ^~~~~~~
fs/cifs/cifsacl.c:37:3: error: 'struct key_acl' has no member named 'usage'

if CONFIG_KEYS=n and CONFIG_CIFS!=n (eg arm:nhk8815_defconfig).

Guenter



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux