Attached is a patch which addresses a few of them which seem more
important (MOUNT_POSIXACL is SMB1 only so I would prefer not to touch
that one)
On Mon, Jun 24, 2019 at 1:08 AM Steve French <smfrench@xxxxxxxxx> wrote:
>
> I noticed that we don't have these six flags defined in cifsglob.h in
> the CIFS_MOUNT_MASK used to see if superblocks match when doing a
> second mount of the same share
>
> #define CIFS_MOUNT_RWPIDFORWARD 0x80000
> #define CIFS_MOUNT_POSIXACL 0x100000
> #define CIFS_MOUNT_USE_PREFIX_PATH 0x1000000
> #define CIFS_MOUNT_UID_FROM_ACL 0x2000000
> #define CIFS_MOUNT_NO_HANDLE_CACHE 0x4000000
> #define CIFS_MOUNT_MAP_SFM_CHR 0x800000
>
> Any thoughts if any of thes really can be ignored in the check for
> superblock matches?
> --
> Thanks,
>
> Steve
--
Thanks,
Steve
From 6e96c4571b441633f442109cfc13e2f9c11010a3 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@xxxxxxxxxxxxx>
Date: Mon, 24 Jun 2019 01:19:52 -0500
Subject: [PATCH] cifs: Fix check for matching with existing mount
If we mount the same share twice, we check the flags to see if the
second mount matches the earlier mount, but we left some flags out.
Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
---
fs/cifs/cifsglob.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 4777b3c4a92c..88c98fa15f39 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -617,6 +617,7 @@ struct smb_vol {
CIFS_MOUNT_FSCACHE | CIFS_MOUNT_MF_SYMLINKS | \
CIFS_MOUNT_MULTIUSER | CIFS_MOUNT_STRICT_IO | \
CIFS_MOUNT_CIFS_BACKUPUID | CIFS_MOUNT_CIFS_BACKUPGID | \
+ CIFS_MOUNT_UID_FROM_ACL | CIFS_MOUNT_NO_HANDLE_CACHE | \
CIFS_MOUNT_NO_DFS)
/**
--
2.20.1
