All of those uses of __constant_cpu_to_le32 apparently (at least according to checkpatch) should be changed (someday) to cpu_to_le32 but I didn't research why the change from __constant_cpu_to_le32 ---> cpu_to_le32 If it has benefit - and checkpatch is right (it warned about __constant_cpu_to_le32 being no longer preferred) ... perhaps would be worth a followup patch to clean the rest of them up? If you have any context on why kernel code has moved away from using the older format of __constant_cpu_to_.... would be useful to know if any benefit to the change On Thu, Mar 14, 2019 at 2:12 AM Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx> wrote: > > On (03/14/19 02:04), Steve French wrote: > [..] > > #define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x0000) > > Does STATUS_SEVERITY_SUCCESS still use __constant_cpu_to_le32? > > > -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001) > > -#define STATUS_SEVERITY_WARNING __constanst_cpu_to_le32(0x0002) > > -#define STATUS_SEVERITY_ERROR __constanst_cpu_to_le32(0x0003) > > +#define STATUS_SEVERITY_INFORMATIONAL cpu_to_le32(0x0001) > > +#define STATUS_SEVERITY_WARNING cpu_to_le32(0x0002) > > +#define STATUS_SEVERITY_ERROR cpu_to_le32(0x0003) > > Otherwise looks good. > > -ss -- Thanks, Steve
