Re: [PATCH][SMB3] Add various dynamic tracepoints for compounded operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 11, 2019 at 5:18 PM Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote:
>
> пн, 11 мар. 2019 г. в 14:25, Steve French <smfrench@xxxxxxxxx>:
> >
> > Sample output from tracing various newly added dynamic trace points
> > (with this patch)
> >
> > (trace-cmd  record -e *query_info_co* -e smb3_hardlink* -e
> > smb3_rename* -e smb3_set_eof* -e smb3_set_info_co* -e smb3_mkdir* -e
> > smb3_delete*)
> >
> > # entries-in-buffer/entries-written: 44/44   #P:8
> > #
> > #                              _-----=> irqs-off
> > #                             / _----=> need-resched
> > #                            | / _---=> hardirq/softirq
> > #                            || / _--=> preempt-depth
> > #                            ||| /     delay
> > #           TASK-PID   CPU#  ||||    TIMESTAMP  FUNCTION
> > #              | |       |   ||||       |         |
> >      gvfsd-trash-2224  [004] .... 333095.401381:
> > smb3_query_info_compound_enter: xid=5 sid=0xbb2583e9 tid=0xe7ab49dc
> >      gvfsd-trash-2224  [002] .... 333095.402056:
> > smb3_query_info_compound_err: xid=5 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >      gvfsd-trash-2224  [002] .... 333095.402189:
> > smb3_query_info_compound_enter: xid=6 sid=0xbb2583e9 tid=0xe7ab49dc
> >      gvfsd-trash-2224  [002] .... 333095.402688:
> > smb3_query_info_compound_err: xid=6 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >            mkdir-16324 [002] .... 333123.559043:
> > smb3_query_info_compound_enter: xid=7 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16324 [003] .... 333123.559654:
> > smb3_query_info_compound_err: xid=7 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >            mkdir-16324 [003] .... 333123.559673: smb3_mkdir_enter:
> > xid=8 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16324 [003] .... 333123.560748: smb3_mkdir_done:
> > xid=8 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16324 [003] .... 333123.560763:
> > smb3_query_info_compound_enter: xid=8 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16324 [003] .... 333123.561516:
> > smb3_query_info_compound_done: xid=8 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16325 [002] .... 333126.841897:
> > smb3_query_info_compound_enter: xid=9 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16325 [003] .... 333126.842580:
> > smb3_query_info_compound_err: xid=9 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >            mkdir-16325 [003] .... 333126.842601: smb3_mkdir_enter:
> > xid=10 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16325 [003] .... 333126.843513: smb3_mkdir_done:
> > xid=10 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16325 [003] .... 333126.843529:
> > smb3_query_info_compound_enter: xid=10 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16325 [003] .... 333126.844251:
> > smb3_query_info_compound_done: xid=10 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16326 [000] .... 333129.858413:
> > smb3_query_info_compound_enter: xid=11 sid=0xbb2583e9 tid=0xe7ab49dc
> >            mkdir-16326 [000] .... 333129.859193:
> > smb3_query_info_compound_done: xid=11 sid=0xbb2583e9 tid=0xe7ab49dc
> >            rmdir-16328 [007] .... 333138.828049:
> > smb3_query_info_compound_enter: xid=12 sid=0xbb2583e9 tid=0xe7ab49dc
> >            rmdir-16328 [007] .... 333138.828827:
> > smb3_query_info_compound_done: xid=12 sid=0xbb2583e9 tid=0xe7ab49dc
> >            rmdir-16329 [006] .... 333141.388154:
> > smb3_query_info_compound_enter: xid=14 sid=0xbb2583e9 tid=0xe7ab49dc
> >            rmdir-16329 [006] .... 333141.388813:
> > smb3_query_info_compound_err: xid=14 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >               rm-16340 [006] .... 333157.935975:
> > smb3_query_info_compound_enter: xid=15 sid=0xbb2583e9 tid=0xe7ab49dc
> >               rm-16340 [006] .... 333157.936607:
> > smb3_query_info_compound_err: xid=15 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >               rm-16340 [006] .... 333157.936652:
> > smb3_query_info_compound_enter: xid=16 sid=0xbb2583e9 tid=0xe7ab49dc
> >               rm-16340 [006] .... 333157.937146:
> > smb3_query_info_compound_err: xid=16 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >            touch-16349 [005] .... 333184.932302:
> > smb3_set_info_compound_enter: xid=18 sid=0xbb2583e9 tid=0xe7ab49dc
> >            touch-16349 [005] .... 333184.938303:
> > smb3_set_info_compound_done: xid=18 sid=0xbb2583e9 tid=0xe7ab49dc
> >               rm-16350 [003] .... 333187.920309:
> > smb3_query_info_compound_enter: xid=20 sid=0xbb2583e9 tid=0xe7ab49dc
> >               rm-16350 [003] .... 333187.920999:
> > smb3_query_info_compound_done: xid=20 sid=0xbb2583e9 tid=0xe7ab49dc
> >               rm-16350 [003] .... 333187.921043: smb3_delete_enter:
> > xid=21 sid=0xbb2583e9 tid=0xe7ab49dc
> >               rm-16350 [003] .... 333187.921870: smb3_delete_done:
> > xid=21 sid=0xbb2583e9 tid=0xe7ab49dc
> >            touch-16361 [005] .... 333237.447252:
> > smb3_set_info_compound_enter: xid=23 sid=0xbb2583e9 tid=0xe7ab49dc
> >            touch-16361 [005] .... 333237.448044:
> > smb3_set_info_compound_done: xid=23 sid=0xbb2583e9 tid=0xe7ab49dc
> >               ln-16366 [000] .... 333250.734035:
> > smb3_query_info_compound_enter: xid=25 sid=0xbb2583e9 tid=0xe7ab49dc
> >               ln-16366 [001] .... 333250.734689:
> > smb3_query_info_compound_err: xid=25 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >               ln-16366 [001] .... 333250.734735:
> > smb3_query_info_compound_enter: xid=26 sid=0xbb2583e9 tid=0xe7ab49dc
> >               ln-16366 [001] .... 333250.735368:
> > smb3_query_info_compound_done: xid=26 sid=0xbb2583e9 tid=0xe7ab49dc
> >               ln-16366 [001] .... 333250.735413:
> > smb3_query_info_compound_enter: xid=27 sid=0xbb2583e9 tid=0xe7ab49dc
> >               ln-16366 [001] .... 333250.735947:
> > smb3_query_info_compound_err: xid=27 sid=0xbb2583e9 tid=0xe7ab49dc
> > rc=-2
> >               ln-16366 [001] .... 333250.735973: smb3_hardlink_enter:
> > xid=28 sid=0xbb2583e9 tid=0xe7ab49dc
> >               ln-16366 [001] .... 333250.736679: smb3_hardlink_done:
> > xid=28 sid=0xbb2583e9 tid=0xe7ab49dc
> >            gmain-2225  [000] .... 333250.736855:
> > smb3_query_info_compound_enter: xid=29 sid=0xbb2583e9 tid=0xe7ab49dc
> >            gmain-2225  [001] .... 333250.737527:
> > smb3_query_info_compound_done: xid=29 sid=0xbb2583e9 tid=0xe7ab49dc
>
> Let's add full paths to the logs to increase usability - this way we
> can match logs with particular actions in the user space.

ok - will add

> Also please don't remove the blank line - the 2nd change in the patch:

That was a typo - will fix



-- 
Thanks,

Steve




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux