вт, 26 февр. 2019 г. в 20:05, Steve French <smfrench@xxxxxxxxx>: > > Adds dynamic trace points for the query_info_enter > and query_info_done (no error) case. We only had one on query_info > errors in existing code. These two tracepoints are for the > non-compounded query_info paths. > > Sample output (after doing: trace-cmd record -e smb3_query_info*) > > # trace-cmd show > # tracer: nop > # > # _-----=> irqs-off > # / _----=> need-resched > # | / _---=> hardirq/softirq > # || / _--=> preempt-depth > # ||| / delay > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > # | | | |||| | | > ls-24140 [001] .... 27811.866068: smb3_query_info_enter: > xid=7 sid=0xd2d00587 tid=0xb5441939 fid=0xcf082bac class=18 type=0x1 > ls-24140 [001] .... 27811.867656: smb3_query_info_done: > xid=7 sid=0xd2d00587 tid=0xb5441939 fid=0xcf082bac class=18 type=0x1 > getcifsacl-24149 [005] .... 27854.759873: smb3_query_info_enter: > xid=15 sid=0xd2d00587 tid=0xb5441939 fid=0x99896e72 class=0 type=0x3 > getcifsacl-24149 [005] .... 27854.761730: smb3_query_info_done: > xid=15 sid=0xd2d00587 tid=0xb5441939 fid=0x99896e72 class=0 type=0x3 Don't we need to trace errors after smb2_validate_and_copy_iov (the same way we do for query_dir)? Other than that the patch looks good. Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx> -- Best regards, Pavel Shilovsky
