I don't have strong opinion on the two different trace points for rc=0
error no more files ('query_dir_done') instead of collapsing that into
a 'query_dir_error' with rc=0 - but seems a little clearer to not log
an rc=0 as an error
On Mon, Feb 25, 2019 at 8:32 PM ronnie sahlberg
<ronniesahlberg@xxxxxxxxx> wrote:
>
> In the first patch, do we really need different tracepoints for done
> rc==0 and err rc!=0 ?
>
> Othervise, for both:
>
> Reweived-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
>
> On Tue, Feb 26, 2019 at 6:53 AM Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > Sample output (from "trace-cmd record -e smb3_query* -e smb3_read* -e
> > smb3_write*")
> >
> > # TASK-PID CPU# |||| TIMESTAMP FUNCTION
> > # | | | |||| | |
> > ls-25909 [004] .... 91084.368421: smb3_query_dir_enter:
> > xid=8 sid=0x45a21759 tid=0x821ad8fd fid=0x50da7b4 offset=0x0
> > len=0x4000
> > ls-25909 [004] .... 91084.369413: smb3_query_dir_done:
> > xid=8 sid=0x45a21759 tid=0x821ad8fd fid=0x50da7b4 offset=0x0 len=0x8
> > ls-25909 [004] .... 91084.369530: smb3_query_dir_enter:
> > xid=9 sid=0x45a21759 tid=0x821ad8fd fid=0x50da7b4 offset=0x0
> > len=0x4000
> > ls-25909 [004] .... 91084.370020: smb3_query_dir_done:
> > xid=9 sid=0x45a21759 tid=0x821ad8fd fid=0x50da7b4 offset=0x0 len=0x0
> > dd-25915 [004] .... 91101.999225: smb3_read_enter: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x85b15605 offset=0x0 len=0x400000
> > cifsd-25891 [005] .... 91102.010600: smb3_read_done: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x85b15605 offset=0x0 len=0x400000
> > dd-25915 [004] .... 91102.015131: smb3_read_enter: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x85b15605 offset=0x400000
> > len=0x3d0000
> > cifsd-25891 [005] .... 91102.026541: smb3_read_done: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x85b15605 offset=0x400000
> > len=0x3d0000
> > dd-25915 [004] .... 91102.028261: smb3_read_enter: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x85b15605 offset=0x7d0000
> > len=0x1000
> > dd-25919 [006] .... 91121.554908: smb3_write_enter:
> > xid=0 sid=0x45a21759 tid=0x821ad8fd fid=0x402ee709 offset=0x0
> > len=0x400000
> > dd-25919 [006] .... 91121.556448: smb3_write_enter:
> > xid=0 sid=0x45a21759 tid=0x821ad8fd fid=0x402ee709 offset=0x400000
> > len=0x3d0000
> > cifsd-25891 [005] .... 91121.559831: smb3_write_done: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x402ee709 offset=0x0 len=0x400000
> > cifsd-25891 [005] .... 91121.561798: smb3_write_done: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x402ee709 offset=0x400000
> > len=0x3d0000
> > dd-25931 [007] .... 91161.643194: smb3_read_enter: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x115afb41 offset=0x0 len=0x400000
> > cifsd-25891 [005] .... 91161.650859: smb3_read_done: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x115afb41 offset=0x0 len=0x400000
> > dd-25931 [007] .... 91161.655470: smb3_read_enter: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x115afb41 offset=0x400000
> > len=0x3d0000
> > cifsd-25891 [004] .... 91161.663517: smb3_read_done: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x115afb41 offset=0x400000
> > len=0x3d0000
> > dd-25931 [001] .... 91161.664921: smb3_read_enter: xid=0
> > sid=0x45a21759 tid=0x821ad8fd fid=0x115afb41 offset=0x7d0000
> > len=0x1000
> >
> >
> > --
> > Thanks,
> >
> > Steve
--
Thanks,
Steve
