вс, 24 февр. 2019 г. в 23:11, Steve French <smfrench@xxxxxxxxx>: > > May be helpful to get timing info for large reads/writes/query_dirs or > to better find hangs or operations that trigger reconnects. Sample > output from various readdirs with the new tracepoints > > # trace-cmd show > # tracer: nop > # > # _-----=> irqs-off > # / _----=> need-resched > # | / _---=> hardirq/softirq > # || / _--=> preempt-depth > # ||| / delay > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > # | | | |||| | | > ls-30820 [004] .... 77492.662476: smb3_query_dir_enter: > xid=8 sid=0x2fa2c9ab tid=0x1377432b fid=0xfc37e912 offset=0x0 > len=0x4000 > ls-30820 [004] .... 77492.663906: smb3_query_dir_done: > xid=8 sid=0x2fa2c9ab tid=0x1377432b fid=0xfc37e912 offset=0x0 len=0x13 > ls-30820 [004] .... 77492.664107: smb3_query_dir_enter: > xid=9 sid=0x2fa2c9ab tid=0x1377432b fid=0xfc37e912 offset=0x0 > len=0x4000 > ls-30820 [004] .... 77492.664639: smb3_query_dir_err: > xid=9 sid=0x2fa2c9ab tid=0x1377432b fid=0xfc37e912 offset=0x0 len=0x0 > rc=0 > bash-27628 [000] .... 77502.150630: smb3_query_dir_enter: > xid=12 sid=0x2fa2c9ab tid=0x1377432b fid=0x26e379e1 offset=0x0 > len=0x4000 > bash-27628 [000] .... 77502.151783: smb3_query_dir_done: > xid=12 sid=0x2fa2c9ab tid=0x1377432b fid=0x26e379e1 offset=0x0 > len=0x13 > bash-27628 [000] .... 77502.151855: smb3_query_dir_enter: > xid=13 sid=0x2fa2c9ab tid=0x1377432b fid=0x26e379e1 offset=0x0 > len=0x4000 > bash-27628 [000] .... 77502.152378: smb3_query_dir_err: > xid=13 sid=0x2fa2c9ab tid=0x1377432b fid=0x26e379e1 offset=0x0 > len=0x0 rc=0 query_dir_ERR and rc=0 looks weird, should be query_dir_DONE. > ls-30821 [001] .... 77502.156573: smb3_query_dir_enter: > xid=15 sid=0x2fa2c9ab tid=0x1377432b fid=0x4f5cedcd offset=0x0 > len=0x4000 > ls-30821 [001] .... 77502.157308: smb3_query_dir_done: > xid=15 sid=0x2fa2c9ab tid=0x1377432b fid=0x4f5cedcd offset=0x0 len=0x3 > ls-30821 [001] .... 77502.157364: smb3_query_dir_enter: > xid=16 sid=0x2fa2c9ab tid=0x1377432b fid=0x4f5cedcd offset=0x0 > len=0x4000 > ls-30821 [001] .... 77502.157880: smb3_query_dir_err: > xid=16 sid=0x2fa2c9ab tid=0x1377432b fid=0x4f5cedcd offset=0x0 > len=0x0 rc=0 > ls-30821 [001] .... 77502.159819: smb3_query_dir_enter: > xid=18 sid=0x2fa2c9ab tid=0x1377432b fid=0xcb88f96d offset=0x0 > len=0x4000 > ls-30821 [003] .... 77502.160591: smb3_query_dir_done: > xid=18 sid=0x2fa2c9ab tid=0x1377432b fid=0xcb88f96d offset=0x0 len=0x3 > ls-30821 [003] .... 77502.160651: smb3_query_dir_enter: > xid=19 sid=0x2fa2c9ab tid=0x1377432b fid=0xcb88f96d offset=0x0 > len=0x4000 > ls-30821 [003] .... 77502.161106: smb3_query_dir_err: > xid=19 sid=0x2fa2c9ab tid=0x1377432b fid=0xcb88f96d offset=0x0 > len=0x0 rc=0 > ls-30821 [003] .... 77502.162653: smb3_query_dir_enter: > xid=21 sid=0x2fa2c9ab tid=0x1377432b fid=0x9ca0a6bc offset=0x0 > len=0x4000 > ls-30821 [003] .... 77502.163334: smb3_query_dir_done: > xid=21 sid=0x2fa2c9ab tid=0x1377432b fid=0x9ca0a6bc offset=0x0 len=0x3 > ls-30821 [003] .... 77502.163382: smb3_query_dir_enter: > xid=22 sid=0x2fa2c9ab tid=0x1377432b fid=0x9ca0a6bc offset=0x0 > len=0x4000 > ls-30821 [003] .... 77502.163894: smb3_query_dir_err: > xid=22 sid=0x2fa2c9ab tid=0x1377432b fid=0x9ca0a6bc offset=0x0 > len=0x0 rc=0 > Other than the comment above, the patch looks fine Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx> -- Best regards, Pavel Shilovsky
