smbclient requests even more for every request - although server will give out a much, much smaller number in reponse. If there were another safe request to add more to (perhaps validate negotiate) we should be up to a reasonable number of credits even for parallel i/o right after mount - in any case it will increase over time (the number of credits) but perhaps we should more aggressively ask for credits on each request and go from asking for 2 for all non read/write requests to asking for 64 or 128 On Thu, Feb 14, 2019 at 2:05 AM Ronnie Sahlberg <lsahlber@xxxxxxxxxx> wrote: > > In libsmb2 I am very aggressive about requesting credits during early session establish without problems > so I am confident we could even dial this up to say 1000 credits. > > Though 105 might be more than sufficient. > > ----- Original Message ----- > From: "Steve French" <smfrench@xxxxxxxxx> > To: "CIFS" <linux-cifs@xxxxxxxxxxxxxxx> > Sent: Thursday, 14 February, 2019 5:27:41 PM > Subject: [SMB3][PATCH] request more credits during session setup > > We only request significantly more credits (during mount) on first > session setup so we typically end up with from 43-49 credits available > when mount completes - which is not enough for a large I/O to complete > (if started soon after mount). We need > 64 credits. Solve this by > requesting more than 2 credits on tree connect. > > After mount (before this patch): > 43 credits (not enough for a 4MB I/O) > > After mount (with this patch) > 105 credits (which is good, enough for two large I/Os to be issued > immediately after mount) > > > -- > Thanks, > > Steve -- Thanks, Steve
