I prefer to only document the most useful ones to make it more
readable (allinfo is something users would use - the others are
developer only and included in the allinfo) to make it easier to read
- or add a verbose help if we really want to list all of them.
For example - see attached.
There may be other ways to make it more readable though
On Tue, Feb 12, 2019 at 11:47 PM Ronnie Sahlberg <lsahlber@xxxxxxxxxx> wrote:
>
> Signed-off-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
> ---
> smbinfo.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/smbinfo.c b/smbinfo.c
> index de9ebf6..c2cea9e 100644
> --- a/smbinfo.c
> +++ b/smbinfo.c
> @@ -57,6 +57,24 @@ usage(char *name)
> {
> fprintf(stderr, "Usage: %s <command> <file>\n"
> "Commands are\n"
> + " fileaccessinfo:\n"
> + " Prints FileAccessInfo for a cifs file.\n"
> + " filealigninfo:\n"
> + " Prints FileAlignInfo for a cifs file.\n"
> + " fileallinfo:\n"
> + " Prints FileAllInfo for a cifs file.\n"
> + " filebasicinfo:\n"
> + " Prints FileBasicInfo for a cifs file.\n"
> + " fileeainfo:\n"
> + " Prints FileEAInfo for a cifs file.\n"
> + " fileinternalinfo:\n"
> + " Prints FileInternalInfo for a cifs file.\n"
> + " filemodeinfo:\n"
> + " Prints FileModeInfo for a cifs file.\n"
> + " filepositioninfo:\n"
> + " Prints FilePositionInfo for a cifs file.\n"
> + " filestandardinfo:\n"
> + " Prints FileStandardInfo for a cifs file.\n"
> " secdesc:\n"
> " Prints the security descriptor for a cifs file.\n"
> " quota:\n"
> --
> 2.15.1
>
--
Thanks,
Steve
From 34afd492b3030002bc93b5505dd0df358dce1e69 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@xxxxxxxxxxxxx>
Date: Tue, 29 Jan 2019 07:03:01 -0600
Subject: [PATCH] smbinfo: update help text
Add description for fileallinfo query option.
Note that there are eight other recently added query options, but they
are mostly a subset a "fileallinfo" so could be of little value
(and may even be very confusing if we documented all nine in the
help text in smbinfo, instead of just this one). The man page
has a full description of them.
Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
---
smbinfo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/smbinfo.c b/smbinfo.c
index de9ebf6..a5a0041 100644
--- a/smbinfo.c
+++ b/smbinfo.c
@@ -57,6 +57,8 @@ usage(char *name)
{
fprintf(stderr, "Usage: %s <command> <file>\n"
"Commands are\n"
+ " fileallinfo:\n"
+ " Prints common metadata associated with a file.\n"
" secdesc:\n"
" Prints the security descriptor for a cifs file.\n"
" quota:\n"
--
2.17.1
