Re: [PATCH] Update mount.cifs with vers=default mount option.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 12, 2018 at 9:14 PM, Tom Talpey <ttalpey@xxxxxxxxxxxxx> wrote:
>> -----Original Message-----
>> From: linux-cifs-owner@xxxxxxxxxxxxxxx <linux-cifs-owner@xxxxxxxxxxxxxxx> On
>> Behalf Of Kenneth D'souza
>> Sent: Saturday, November 10, 2018 9:28 AM
>> To: linux-cifs@xxxxxxxxxxxxxxx
>> Cc: piastryyy@xxxxxxxxx; smfrench@xxxxxxxxx
>> Subject: [PATCH] Update mount.cifs with vers=default mount option.
>>
>> Signed-off-by: Kenneth D'souza <kdsouza@xxxxxxxxxx>
>> ---
>>  mount.cifs.rst | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/mount.cifs.rst b/mount.cifs.rst
>> index 405c459..19f9956 100644
>> --- a/mount.cifs.rst
>> +++ b/mount.cifs.rst
>> @@ -543,6 +543,10 @@ vers=arg
>>    - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7
>> and Windows Server 2008R2.
>>    - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8
>> and Windows Server 2012.
>
> Shouldn't the 3.0.2 dialect be mentioned here?
>

I will mention the same in V2.
Something like the below ?
3.02 - The SMBv3.02 protocol that was introduced in Windows 8.1
(Windows 'Blue') and Windows Server 2012 R2.

>>    - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft
>> Windows Server 2016.
>> +  - default - Tries to negotiate the highest possible version supported by the
>> server.
>
> The "highest" version is not universally the case, where SMB1 is involved. It would
> be safer to say "highest SMB2+ version" perhaps.
>
Agreed, will update the same.

>> +
>> +  If no dialect is specified on mount vers=default is used.
>> +  To check ``Dialect`` refer to /proc/fs/cifs/DebugData
>>
>>    Note too that while this option governs the protocol version used, not
>>    all features of each version are available.
>> --
>> 2.17.2
>



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux