On Thu, Nov 1, 2018 at 11:06 AM Julia Lawall <julia.lawall@xxxxxxx> wrote: > > On Thu, 1 Nov 2018, Steve French wrote: d> > > On Thu, Nov 1, 2018 at 10:18 AM Julia Lawall <julia.lawall@xxxxxxx> wrote: > > > > > > On Thu, 1 Nov 2018, Steve French wrote: > > > > > > > > ssize_t iov_iter_get_pages_alloc(struct iov_iter *i, > > > > struct page ***pages, size_t maxsize, > > > > size_t *start) > > > > > > The return type is ssize_t not size_t. Putting a negative value into a > > > size_t variable makes it positive > > > > > > Aah - I misread the extra s (ssize_t vs. size_t) that is missing in his patch. > > > > How about this trivial fix (attached) - > > It looks fine. There is though an extra space between result and =, and > it seems checkpatch does not like function calls that end with an open > parenthesis. But, up to you. > > julia > Fixed the extra space - thx checkpatch didn't complain on my system about the parentheses. -- Thanks, Steve
