Hi Steve! o/ Appreciate your time and review. For a v3, what would you like more: a pr_info() straight away in the code for the message, or, writing a new cifs_info() function wrapping over pr_info, like we have in cifs_dbg (which translates to pr_debug or pr_err)? Waiting for your comments. Thanks! --- Rodrigo Freire - Principal Technical Account Manager GLOBAL CUSTOMER SUCCESS - Partnering with you to help achieve your business goals redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted ----- Original Message ----- > From: "Steve French" <smfrench@xxxxxxxxx> > To: rfreire@xxxxxxxxxx > Cc: "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "Steve French" > <sfrench@xxxxxxxxx>, "CIFS" <linux-cifs@xxxxxxxxxxxxxxx>, "Pavel Shilovsky" > <piastryyy@xxxxxxxxx> > Sent: Saturday, October 6, 2018 4:09:30 PM > Subject: Re: [PATCH v2] CIFS: Print message when attempting a mount > On Tue, Oct 2, 2018 at 4:53 PM Rodrigo Freire <rfreire@xxxxxxxxxx> wrote: > > > > Hi hi again Steve \o > > > > I do see potential for a ftrace rewrite for the cifs_dbg messages. > Was looking at this on current kernels and debugging mount is probably > fine for developers (or users) - plenty of debug messages get printed > via the dynamic ftrace points. In practice some would prefer less > noisy trace logs so the minimum set for some would be something like > this (which already works with current cifs). If we want to add some > default log messages on mount to dmesg instead of the trace-cmd log, > maybe we should log them at a slightly less noisy level (as we see > with xfs and btrfs) so they will be more log friendly > root@smf-Thinkpad~/# trace-cmd record -e smb3_enter* -e smb3_exit* > Hit Ctrl^C to stop recording > root@smf-Thinkpad:~/# trace-cmd show > # tracer: nop > # > # _-----=> irqs-off > # / _----=> need-resched > # | / _---=> hardirq/softirq > # || / _--=> preempt-depth > # ||| / delay > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > # | | | |||| | | > mount.cifs-14199 [002] .... 97642.728411: smb3_enter: > cifs_mount: xid=20 > mount.cifs-14199 [002] .... 97642.728669: smb3_enter: > cifs_get_smb_ses: xid=21 > mount.cifs-14199 [003] .... 97642.742336: smb3_exit_done: > cifs_get_smb_ses: xid=21 > mount.cifs-14199 [003] .... 97642.742343: smb3_enter: > cifs_setup_ipc: xid=22 > mount.cifs-14199 [003] .... 97642.742530: smb3_exit_done: > cifs_setup_ipc: xid=22 > mount.cifs-14199 [003] .... 97642.742532: smb3_enter: > cifs_get_tcon: xid=23 > mount.cifs-14199 [003] .... 97642.742674: smb3_exit_done: > cifs_get_tcon: xid=23 > mount.cifs-14199 [003] .... 97642.743267: smb3_exit_done: > cifs_mount: xid=20 > mount.cifs-14199 [003] .... 97642.743311: smb3_enter: > cifs_root_iget: xid=24 > mount.cifs-14199 [003] .... 97642.743471: smb3_exit_done: > cifs_root_iget: xid=24 > -- > Thanks, > Steve
