Re: [PATCH] cifs: add IOCTL for QUERY_INFO passthrough to userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There's an issue with the ioctl against directories as Steve might have
told you:

Ronnie Sahlberg <lsahlber@xxxxxxxxxx> writes:
>  
> +static long cifs_ioctl_query_info(unsigned int xid, struct file *filep,
> +				  unsigned long p)
> +{
> +	struct cifsFileInfo *pSMBFile = filep->private_data;

private_data is NULL for directories so we get an Oops.

It turns out neither cifs_open() nor cifs_atomic_open() is called when
we call open(dir) from userspace...

> +	struct cifs_tcon *tcon;
> +
> +	tcon = tlink_tcon(pSMBFile->tlink);
> +
> +	if (tcon->ses->server->ops->ioctl_query_info)
> +		return tcon->ses->server->ops->ioctl_query_info(
> +				xid, pSMBFile, p);
> +	else
> +		return -EOPNOTSUPP;
> +}
> +

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux