Re: [PATCH] smb3: do not display confusing message on mount to Azure servers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>

On Fri, Sep 14, 2018 at 6:16 AM, Steve French <smfrench@xxxxxxxxx> wrote:
> Some servers (e.g. Azure) return "STATUS_NOT_IMPLEMENTED" rather
> than "STATUS_INVALID_DEVICE_REQUEST" on query network interface
> info at mount.  This shouldn't cause us to log a warning message
> automatically but does because we were not checking for ENOSYS.
> According to checkpatch we shouldn't be using ENOSYS for this
> in any case so fix it by mappoing to EOPNOTSUPP so we
> don't log this unless noisier cifsFYI is enabled.
>
> Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
>
>  fs/cifs/smb2maperror.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c
> index 20a2d304c603..d47b7f5dfa6c 100644
> --- a/fs/cifs/smb2maperror.c
> +++ b/fs/cifs/smb2maperror.c
> @@ -288,7 +288,7 @@ static const struct status_to_posix_error
> smb2_error_map_table[] = {
>      {STATUS_FLT_BUFFER_TOO_SMALL, -ENOBUFS, "STATUS_FLT_BUFFER_TOO_SMALL"},
>      {STATUS_FVE_PARTIAL_METADATA, -EIO, "STATUS_FVE_PARTIAL_METADATA"},
>      {STATUS_UNSUCCESSFUL, -EIO, "STATUS_UNSUCCESSFUL"},
> -    {STATUS_NOT_IMPLEMENTED, -ENOSYS, "STATUS_NOT_IMPLEMENTED"},
> +    {STATUS_NOT_IMPLEMENTED, -EOPNOTSUPP, "STATUS_NOT_IMPLEMENTED"},
>      {STATUS_INVALID_INFO_CLASS, -EIO, "STATUS_INVALID_INFO_CLASS"},
>      {STATUS_INFO_LENGTH_MISMATCH, -EIO, "STATUS_INFO_LENGTH_MISMATCH"},
>      {STATUS_ACCESS_VIOLATION, -EACCES, "STATUS_ACCESS_VIOLATION"},
>
> --
> Thanks,
>
> Steve



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux