patch removed On Wed, Sep 5, 2018 at 9:30 AM Steve French <smfrench@xxxxxxxxx> wrote: > > On Tue, Sep 4, 2018 at 9:11 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > On Mon, Sep 03, 2018 at 04:57:33PM +1000, Ronnie Sahlberg wrote: > > > Add a new ioctl for COPYCHUNK that copies a region. The existing > > > COPYCHUNK can only be used to copy a whole file. > > > > Please don't add magic ioctls and reuse the existing kernel copy > > offload functionality. > > The existing kernel copy offload syscall does overlap the proposed > ioctl, so until > additional feature rich SMB3 copy offload mechanisms are added (ODX might > be a good example) require interface features not supported by the syscall > (and thus require a cifs specific ioctl), we might as well avoid confusion > and drop this patch. > > Now if any useful copy tools (rsync, gio copy etc.) actually used the copy > syscall that would be even better - but that is a different problem ... > -- > Thanks, > > Steve -- Thanks, Steve
