Re: [PATCH] cifs: check if SMB2 PDU size has been padded and suppress the warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ronnie Sahlberg <lsahlber@xxxxxxxxxx> writes:
> +		 */
> +		if (((clc_len + 7) & ~7) == len)
> +			return 0;

Kind of nitpicking but we could use the roundup() helper ie: roundup(clc_len, 8) == len
It's more readable and compiles to the same thing. Otherwise looks good.

Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx>

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux