This is an alias not a change to the name. We don't want to remove
the 'cifs' names for years if there is a risk of breaking apps - but
we might as well starting moving them now.
On Fri, Aug 10, 2018 at 11:56 PM Steve French <smfrench@xxxxxxxxx> wrote:
>
> no - my purpose was to give instructions in the future with the new
> name so people won't be confused (old apps can keep using what cifsacl
> does e.g. and use the "cifs" in the name).
> The patch is so small - no need to worry about breaking old apps ...
> we can keep "cifs" alias around on these attributes for a long time -
> but it is very confusing when cifs has been (supposedly) dead for many
> years now, to keep telling people instructions with that name in it.
> To avoid breaking things - I don't mind keeping a few dozen lines of
> extra code ... (with "cifs" legacy names).
> On Fri, Aug 10, 2018 at 11:48 PM ronnie sahlberg
> <ronniesahlberg@xxxxxxxxx> wrote:
> >
> > I am not sure this is the way to go.
> >
> > I do understand the desire to purge the word "cifs" from where we are
> > now but this essentially will fork the namespace between new clients
> > with new kernels and old clients with old kernels.
> > (I am assuming the plan is to in the future WRITE the acls under the
> > new name at which point older kernels/clients will no longer be
> > compatible with the naming.
> >
> >
> >
> >
> > On Sat, Aug 11, 2018 at 9:53 AM, Steve French <smfrench@xxxxxxxxx> wrote:
> > > We really, really don't want to be encouraging people to use
> > > cifs (the dialect) since it is insecure, so to avoid confusion
> > > we want to move them to names which include 'smb3' instead of
> > > 'cifs' - so this simply creates an alias for the pseudo-xattrs
> > >
> > > e.g. can now do:
> > > getfattr -n user.smb3.creationtime /mnt1/file
> > > and
> > > getfattr -n user.smb3.dosattrib /mnt1/file
> > > and
> > > getfattr -n system.smb3_acl /mnt1/file
> > >
> > > instead of forcing you to use the string 'cifs' in
> > > these (e.g. getfattr -n system.cifs_acl /mnt1/file)
> > >
> > > Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
> > > ---
> > > fs/cifs/xattr.c | 28 ++++++++++++++++++++++++++--
> > > 1 file changed, 26 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c
> > > index 316af84674f1..50ddb795aaeb 100644
> > > --- a/fs/cifs/xattr.c
> > > +++ b/fs/cifs/xattr.c
> > > @@ -35,6 +35,14 @@
> > > #define CIFS_XATTR_CIFS_ACL "system.cifs_acl"
> > > #define CIFS_XATTR_ATTRIB "cifs.dosattrib" /* full name:
> > > user.cifs.dosattrib */
> > > #define CIFS_XATTR_CREATETIME "cifs.creationtime" /* user.cifs.creationtime */
> > > +/*
> > > + * Although these three are just aliases for the above, need to move away from
> > > + * confusing users and using the 20+ year old term 'cifs' when it is no longer
> > > + * secure, replaced by SMB2 (then even more highly secure SMB3) many years ago
> > > + */
> > > +#define SMB3_XATTR_CIFS_ACL "system.smb3_acl"
> > > +#define SMB3_XATTR_ATTRIB "smb3.dosattrib" /* full name:
> > > user.smb3.dosattrib */
> > > +#define SMB3_XATTR_CREATETIME "smb3.creationtime" /* user.smb3.creationtime */
> > > /* BB need to add server (Samba e.g) support for security and trusted prefix */
> > >
> > > enum { XATTR_USER, XATTR_CIFS_ACL, XATTR_ACL_ACCESS, XATTR_ACL_DEFAULT };
> > > @@ -220,10 +228,12 @@ static int cifs_xattr_get(const struct
> > > xattr_handler *handler,
> > > switch (handler->flags) {
> > > case XATTR_USER:
> > > cifs_dbg(FYI, "%s:querying user xattr %s\n", __func__, name);
> > > - if (strcmp(name, CIFS_XATTR_ATTRIB) == 0) {
> > > + if ((strcmp(name, CIFS_XATTR_ATTRIB) == 0) ||
> > > + (strcmp(name, SMB3_XATTR_ATTRIB) == 0)) {
> > > rc = cifs_attrib_get(dentry, inode, value, size);
> > > break;
> > > - } else if (strcmp(name, CIFS_XATTR_CREATETIME) == 0) {
> > > + } else if ((strcmp(name, CIFS_XATTR_CREATETIME) == 0) ||
> > > + (strcmp(name, SMB3_XATTR_CREATETIME) == 0)) {
> > > rc = cifs_creation_time_get(dentry, inode, value, size);
> > > break;
> > > }
> > > @@ -363,6 +373,19 @@ static const struct xattr_handler
> > > cifs_cifs_acl_xattr_handler = {
> > > .set = cifs_xattr_set,
> > > };
> > >
> > > +/*
> > > + * Although this is just an alias for the above, need to move away from
> > > + * confusing users and using the 20 year old term 'cifs' when it is no
> > > + * longer secure and was replaced by SMB2/SMB3 a long time ago, and
> > > + * SMB3 and later are highly secure.
> > > + */
> > > +static const struct xattr_handler smb3_acl_xattr_handler = {
> > > + .name = SMB3_XATTR_CIFS_ACL,
> > > + .flags = XATTR_CIFS_ACL,
> > > + .get = cifs_xattr_get,
> > > + .set = cifs_xattr_set,
> > > +};
> > > +
> > > static const struct xattr_handler cifs_posix_acl_access_xattr_handler = {
> > > .name = XATTR_NAME_POSIX_ACL_ACCESS,
> > > .flags = XATTR_ACL_ACCESS,
> > > @@ -381,6 +404,7 @@ const struct xattr_handler *cifs_xattr_handlers[] = {
> > > &cifs_user_xattr_handler,
> > > &cifs_os2_xattr_handler,
> > > &cifs_cifs_acl_xattr_handler,
> > > + &smb3_acl_xattr_handler, /* alias for above since avoiding "cifs" */
> > > &cifs_posix_acl_access_xattr_handler,
> > > &cifs_posix_acl_default_xattr_handler,
> > > NULL
> > >
> > > --
> > > Thanks,
> > >
> > > Steve
>
>
>
> --
> Thanks,
>
> Steve
--
Thanks,
Steve
