Re: [PATCH] cifs-utils: support rst2man-3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alexander Bokovoy <ab@xxxxxxxxx> writes:
>> It's called rst2man-3.4 here, you probably want to check for that too.
> Ok. Added rst2man-{3,3.4,3.6} for completeness.

Good, thanks!

> / Alexander Bokovoy
> From 6f7af37a5b4b450c5e326d20f2a71423aa55606d Mon Sep 17 00:00:00 2001
> From: Alexander Bokovoy <ab@xxxxxxxxx>
> Date: Tue, 17 Jul 2018 08:22:23 +0300
> Subject: [PATCH] configure.ac: support using both rst2man and rst2man-3
>
> Python3 version of rst2man is called rst2man-3.
> Add few more variants to cover Fedora and OpenSUSE.
>
> Signed-off-by: Alexander Bokovoy <ab@xxxxxxxxx>
> ---
>  configure.ac | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index b0bc2b9..8e3d6ce 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -252,12 +252,12 @@ fi
>  
>  # if docs are not disabled, check if rst2man is available
>  if test $enable_man != "no"; then
> -	AC_CHECK_PROG(have_rst2man, rst2man, yes, no)
> +	AC_CHECK_PROGS(have_rst2man, rst2man-3.6 rst2man-3.4 rst2man-3 rst2man, no)

You need to use the variable in the Makefile to actually use the prog
found. It should just be a matter of replacing "rst2man" by
"$(have_rst2man)" since autoconf already calls AC_SUBST on the var
according to AC_CHECK_PROGS documentation.

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux