I really like that the words map directly to CONFIG_CIFS_<xxx> that will make is obvious what each entry in the feature list actually means. ----- Original Message ----- From: "Paulo Alcantara" <paulo@xxxxxxxx> To: "Steve French" <smfrench@xxxxxxxxx>, "CIFS" <linux-cifs@xxxxxxxxxxxxxxx> Sent: Friday, 29 June, 2018 10:05:14 AM Subject: Re: [PATCH] cifs: add missing debug entries for kconfig options Steve French <smfrench@xxxxxxxxx> writes: > /proc/fs/cifs/DebugData displays the features (Kconfig options) > used to build cifs.ko but it was missing some, and needed comma > separator. These can be useful in debugging certain problems > so we know which optional features were enabled in the user's build. > Also clarify them, by making them more closely match the > corresponding CONFIG_CIFS_* parm. > > Old format: > Features: dfs fscache posix spnego xattr acl > > New format: > Features: DFS,FSCACHE,SMB_DIRECT,STATS,DEBUG2,ALLOW_INSECURE_LEGACY,CIFS_POSIX,UPCALL(SPNEGO),XATTR,ACL > > Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx> > CC: Stable <stable@xxxxxxxxxxxxxxx> Looks good, Reviewed-by: Paulo Alcantara <palcantara@xxxxxxx> Paulo -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html