On Sat, Jun 2, 2018 at 12:04 AM, Steve French <smfrench@xxxxxxxxx> wrote: > any thoughts on whether to mark cc:stable? > > I would lean toward marking it for stable I think this should go to stable too. > > > > > > On Tue, May 29, 2018 at 6:32 AM, Mark Syms <Mark.Syms@xxxxxxxxxx> wrote: >> Attached patch that has gone through our automated tests and successfully recovered the session allowing the tests to complete successfully. >> >> Thanks, >> >> Mark. >> >> -----Original Message----- >> From: linux-cifs-owner@xxxxxxxxxxxxxxx [mailto:linux-cifs-owner@xxxxxxxxxxxxxxx] On Behalf Of Mark Syms >> Sent: 24 May 2018 09:09 >> To: Pavel Shilovsky <piastryyy@xxxxxxxxx>; Steve French <smfrench@xxxxxxxxx> >> Cc: linux-cifs@xxxxxxxxxxxxxxx >> Subject: RE: CIFS: Reconnect expired SMB sessions >> >> Sorry, yes, that's what I meant by my question, i.e. would it be reasonable for this to be checking several status values and triggering a reconnect? (Which it seems it would be) >> >> As I have a test suite which gives an about 1 in 10 reproduction of this error I' try tweaking this to consider SESSION_DELETED and see if that resolves the issue for us and then RFC a commit. >> >> Thanks, >> >> Mark. >> >> -----Original Message----- >> From: linux-cifs-owner@xxxxxxxxxxxxxxx <linux-cifs-owner@xxxxxxxxxxxxxxx> On Behalf Of Pavel Shilovsky >> Sent: 22 May 2018 19:25 >> To: Mark Syms <Mark.Syms@xxxxxxxxxx>; Steve French <smfrench@xxxxxxxxx> >> Cc: linux-cifs@xxxxxxxxxxxxxxx >> Subject: Re: CIFS: Reconnect expired SMB sessions >> >> 2018-05-22 5:51 GMT-07:00 Mark Syms <Mark.Syms@xxxxxxxxxx>: >>> Should commit 511c54a2f69195b28afb9dd119f03787b1625bb4, (CIFS: Reconnect expired SMB sessions) also be considering STATUS_USER_SESSION_DELETED to be equivalent to STATUS_NETWORK_SESSION_EXPIRED and triggering a reconnect? We're seeing STATUS_USER_SESSION_DELETED occurring in some of our automated testing and it looks like the server has reaped the session due to it being idle for a period of time. >>> >>> Thanks, >>> >>> Mark. >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-cifs" >>> in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo >>> info at http://vger.kernel.org/majordomo-info.html >> >> No. Currently we only reconnect on STATUS_NETWORK_SESSION_EXPIRED error code as a special case. It seems that we should consider making this check more generic by checking for STATUS_USER_SESSION_DELETED and possibly other error codes and reconnect. >> >> -- >> Best regards, >> Pavel Shilovsky >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html >> 칻 & ~ & +- ݶ w ˛ m b \ " ^n r z h & G h ( 階 ݢj" m z ޖ f h ~ m > > > > -- > Thanks, > > Steve > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
