Minor build error (eg if you look at the first 8) - otherwise, at least the first five look ok to me (fixed a trivial spelling error) other than the one comment earlier about the typo CHECK fs/cifs/smb2misc.c fs/cifs/smb2misc.c:226:45: error: undefined identifier 'hdr' CC [M] fs/cifs/smb2misc.o fs/cifs/smb2misc.c:97:38: warning: ‘struct smb2_hdr’ declared inside parameter list will not be visible outside of this definition or declaration static __u32 get_neg_ctxt_len(struct smb2_hdr *hdr, __u32 len, __u32 non_ctxlen) ^~~~~~~~ fs/cifs/smb2misc.c: In function ‘smb2_check_message’: fs/cifs/smb2misc.c:226:31: error: ‘hdr’ undeclared (first use in this function); did you mean ‘shdr’? clc_len += get_neg_ctxt_len(hdr, len, clc_len); ^~~ shdr fs/cifs/smb2misc.c:226:31: note: each undeclared identifier is reported only once for each function it appears in scripts/Makefile.build:312: recipe for target 'fs/cifs/smb2misc.o' failed make[1]: *** [fs/cifs/smb2misc.o] Error 1 Makefile:1571: recipe for target '_module_fs/cifs' failed make: *** [_module_fs/cifs] Error 2 On Tue, May 29, 2018 at 7:47 PM, Ronnie Sahlberg <lsahlber@xxxxxxxxxx> wrote: > Steve, All > > Please see an updated version for plumbing we need for compounding. > They are based on current for-next and it > passes the same xfstests for smb2 with these patches as without. > > I.e. it passes > sudo ./check -s smb2 -E tests/cifs/exclude.incompatible-smb2 \ > -E tests/cifs/exclude.very-slow > > These patches have gone through a lot of testing by now and few rounds > of review. > Please focus on patches 1-8, if we can get these into for-next > then that would be awesome. > > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html