Add Ronnie to to list. Hello Ronnie, what's the expected behavior from CIFS on atime/noatime? We want to skip the atime related tests on cifs for xfstests just like nfs. But not sure if it's correct. What do you think about it? Thanks. ----- Original Message ----- > From: "Eryu Guan" <guaneryu@xxxxxxxxx> > To: "XiaoLi Feng" <xifeng@xxxxxxxxxx> > Cc: fstests@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx > Sent: Sunday, May 27, 2018 8:50:58 PM > Subject: Re: [PATCH] common/rc: skip atime related tests on CIFS > > On Tue, May 22, 2018 at 11:23:56AM +0800, Xiaoli Feng wrote: > > From: xiaoli feng <xifeng@xxxxxxxxxx> > > > > The atime related mount options have no effect on cifs mounts > > now or in the future. So skip these tests on CIFS. > > > > Signed-off-by: xiaoli feng <xifeng@xxxxxxxxxx> > > Looks fine to me. But I really need an ACK from cifs folks. > > > --- > > common/rc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/common/rc b/common/rc > > index ffe5323..d3af55f 100644 > > --- a/common/rc > > +++ b/common/rc > > @@ -3244,6 +3244,8 @@ _require_atime() > > _exclude_scratch_mount_option "noatime" > > if [ "$FSTYP" == "nfs" ]; then > > _notrun "atime related mount options have no effect on NFS" > > + elif [ "$FSTYP" == "cifs" ]; then > > + _notrun "atime related mount options have no effect on CIFS" > > Or just change the check to a case-switch on $FSTYP? Ok, I will change it on the next commit. Thanks! > > Thanks, > Eryu > > > fi > > } > > > > -- > > 1.8.3.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe fstests" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
