Re: [PATCH v1] cifs: smb2ops: Fix listxattr() when there are no EAs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 4, 2018 at 9:38 AM, David Disseldorp <ddiss@xxxxxxx> wrote:
> On Fri, 04 May 2018 16:35:27 +0200, Aurélien Aptel wrote:
>
>> The bug can be triggered by listing the xattr with getfattr on a samba
>> smb2 mount point:
>>
>>     $ echo foo > foo.txt ; getfattr foo.txt ; echo $?
>>     getfattr: foo.txt: No such attribute
>>     1
>>
>> vs on an xfs mount point and on a patched kernel:
>>
>>     $ echo foo > foo.txt ; getfattr foo.txt ; echo $?
>>     0
>
> Is there already coverage of this in xfstests? If not, please make sure
> it gets submitted.

That is a good point.

The new xfstest could be mount with nouser_xattr and see what happens
(as we see with tests which append other mount options like nodiratime
etc.)

user_xattr Enables Extended User Attributes. Additionally, you
need to have extended attribute support enabled in the
kernel configuration (CONFIG_EXT4_FS_XATTR). See the
attr(5) manual page and http://acl.bestbits.at/ to
learn more about extended attributes.

nouser_xattr Disables Extended User Attributes.

-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux