Re: [PATCH] cifs: do not allow creating sockets in SMB1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 18, 2018 at 10:18 PM, ronnie sahlberg
<ronniesahlberg@xxxxxxxxx> wrote:
> re-send in ascii
>
> man 2 mknod says EPERM is what we should use here.:
>
>        EPERM  mode requested creation of something other than a regular
> file,
>               FIFO  (named pipe), or UNIX domain socket, and the caller is
> not
>               privileged (Linux: does not have the CAP_MKNOD capability);
> also
>               returned  if the filesystem containing pathname does not
> support
>               the type of node requested.

ok - looks good . thx

> On Thu, Apr 19, 2018 at 1:12 PM, Steve French <smfrench@xxxxxxxxx> wrote:
>>
>> Looks fine to me - only question is what return code is supposed to be
>> returned - any luck tracking down what other fs return on unsupported
>> types?
>>
>> On Wed, Apr 18, 2018 at 9:48 PM, Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
>> wrote:
>> > RHBZ: 1453123
>> >
>> > Since at least the 3.10 kernel and likely a lot earlier we have
>> > not been able to create unix domain sockets in a cifs share.
>> > Trying to create a socket, for example using the af_unix command from
>> > xfstests will cause :
>> > BUG: unable to handle kernel NULL pointer dereference at 00000000
>> > 00000040

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux