Pavel Shilovskiy <pshilov@xxxxxxxxxxxxx> writes: > Minor: it should probably work this way, but since we set ses->tcon_ipc under a spinlock in cifs_setup_ipc(), it would be better to do something similar here. I was actually thinking that the spinlock might not be necessary for that pointer. It's always only set at session creation (new tcon) and destruction (to null). In between, it's only going to be read. What do you think? >> - /* >> - * BB - map targetUNCs to dfs_info3 structures, here or in >> - * ses->server->ops->get_dfs_refer. >> - */ > > Is this no longer needed? If you are talking about the tcon creation, it is now done all the time at session creation. If you are talking about that specific comment, I believe it's already done now in parse_dfs_referrals(). That function parses the packet into dfs_info3_param structures. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
