RE: [PATCH 1/2] cifs: remove rfc1002 header from all SMB2 response structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: linux-cifs-owner@xxxxxxxxxxxxxxx [mailto:linux-cifs-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Ronnie Sahlberg
> Sent: Tuesday, January 2, 2018 5:35 PM
> To: linux-cifs <linux-cifs@xxxxxxxxxxxxxxx>
> Cc: Steve French <smfrench@xxxxxxxxx>
> Subject: [PATCH 1/2] cifs: remove rfc1002 header from all SMB2 response
> structures
> 
> Separate out all the 4 byte rfc1002 headers so that they are no longer
> part of the SMB2 header structures to prepare for future work to add
> compounding support.
> 
> When using compounding, the wire format will consist of a single
> rfc1002 length header followed by one, or more, SMB2 headers, like this :
> 
> * 4 byte rfc1002 length
> * SMB2 header
> * SMB2 header
> * ...

Comment purely on the changelog.

This second paragraph is somewhat misleading, and should perhaps be omitted.
The RFC1002 length is a transport frame marker, and used only on stream-based
transports such as TCP. For example, it's not present when the transport is
SMB Direct. There is no protocol dependency on its use by Compounding.

Tom.


--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux