On Tue, Dec 19, 2017 at 10:21 PM, Long Li <longli@xxxxxxxxxxxxx> wrote: >> depends on CIFS && INFINIBAND >> + depends on CIFS=m || INFINIBAND=y > > How about we change them to > > depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y > > This makes it easy to read. Yes, that seems fine. I would normally group them using () to avoid any confusion with operator precedence, but your version is also correct, so just pick the one you like best. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html