----- Original Message ----- From: "Pavel Shilovsky" <piastryyy@xxxxxxxxx> To: "Ronnie Sahlberg" <lsahlber@xxxxxxxxxx> Cc: "linux-cifs" <linux-cifs@xxxxxxxxxxxxxxx>, "Steve French" <smfrench@xxxxxxxxx> Sent: Friday, 17 November, 2017 12:42:07 PM Subject: Re: [PATCH 13/19] cifs: remove rfc1002 header from smb2 read/write requests 2017-11-08 17:14 GMT-08:00 Ronnie Sahlberg <lsahlber@xxxxxxxxxx>: > Signed-off-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx> > --- > fs/cifs/smb2pdu.c | 42 ++++++++++++++++++++---------------------- > fs/cifs/smb2pdu.h | 2 +- > 2 files changed, 21 insertions(+), 23 deletions(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > index a44d54ea946b..3ba9b2853902 100644 > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -2471,7 +2471,7 @@ smb2_new_read_req(void **buf, unsigned int *total_len, > struct smb2_sync_hdr *shdr; > > rc = smb2_plain_req_init(SMB2_READ, io_parms->tcon, (void **) &req, > - total_len); > + total_len); > if (rc) > return rc; > if (io_parms->tcon->ses->server == NULL) > @@ -2681,7 +2681,7 @@ SMB2_read(const unsigned int xid, struct cifs_io_parms *io_parms, > > iov[0].iov_base = &req_len; > iov[0].iov_len = sizeof(__be32); > - iov[1].iov_base = req; > + iov[1].iov_base = (char *)req; > iov[1].iov_len = total_len; > > rc = cifs_send_recv(xid, ses, &rqst, &resp_buftype, flags, &rsp_iov); > Why do not convert it to use new smb2_send_recv() function? Good point. Do you want me to do that change as a follow up patch or should I edit and re-send the patch series ? -- Best regards, Pavel Shilovsky -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
