2017-11-04 4:33 GMT-07:00 Jeff Layton <jlayton@xxxxxxxxxx>: > On Tue, 2017-10-31 at 10:45 -0700, Pavel Shilovsky wrote: >> 2017-10-31 9:02 GMT-07:00 Jeff Layton <jlayton@xxxxxxxxxx>: >> > From: Jeff Layton <jlayton@xxxxxxxxx> >> > >> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx> >> > --- >> > mount.cifs.rst | 6 ++++-- >> > 1 file changed, 4 insertions(+), 2 deletions(-) >> > >> > Thanks Aurelien. I dropped Ronnie's Reviewed-by since this is a bit different. >> > Let me know if you'd like me to add it back. >> > >> > diff --git a/mount.cifs.rst b/mount.cifs.rst >> > index 9714f795fe76..01305df60651 100644 >> > --- a/mount.cifs.rst >> > +++ b/mount.cifs.rst >> > @@ -517,7 +517,7 @@ prefixpath=arg >> > vers=arg >> > SMB protocol version. Allowed values are: >> > >> > - - 1.0 - The classic CIFS/SMBv1 protocol. This is the default. >> > + - 1.0 - The classic CIFS/SMBv1 protocol. >> > - 2.0 - The SMBv2.002 protocol. This was initially introduced in >> > Windows Vista Service Pack 1, and Windows Server 2008. Note that >> > the initial release version of Windows Vista spoke a slightly >> > @@ -529,6 +529,9 @@ vers=arg >> > Note too that while this option governs the protocol version used, not >> > all features of each version are available. >> > >> > + In kernels v4.13 and later, the client and server negotiate a version greater >> > + than or equal to ``2.1``. In kernels prior to v4.13, the default is ``1.0``. >> > + >> >> The multi-dialect negotiation (version 2.1 and above) was added in >> v4.13.5 kernel. Should we mention the specific stable version in the >> doc? >> > > It would be very odd to make that sort of change in a stable series > kernel. What patch actually flipped the default to autonegotiate? > > I was assuming that it was eef914a9eb5eb83e60eb498315a491cd1edc13a1: > > $ git tag --contains eef914a9eb5eb83e60eb498315a491cd1edc13a1 | grep v4.13$ > v4.13 > > git says that that commit went into v4.13. Was it a different one? > -- > Jeff Layton <jlayton@xxxxxxxxxx> Yes, it was 9764c02fcbad40001fd3f63558d918e4d519bb75 (https://github.com/torvalds/linux/commit/9764c02fcbad40001fd3f63558d918e4d519bb75). The one you mentioned changed the default from vers=1.0 to vers=3.0 which broke the existing setups against SMB 1.0 only servers. It was done with subsequent auto-negotiate patch in mind. That's why the latter patch should went to v4.13.y. -- Best regards, Pavel Shilovsky -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
