On Fri, Nov 3, 2017 at 4:27 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Nov 02, 2017 at 06:02:54PM +1100, Ronnie Sahlberg wrote: >> This function is similar to SendReceive2 except it does not expect >> a 4 byte rfc1002 length header in the first io vector. > > Can you give it a proper name? cifs_ prefix, lower case with _ > as the word delimiter. Since this will now be the _only_ send/receive function SMB2 uses (except for the two async calls) I can rename it s/SendReceive3/SMB2SendReceive/ ? > > Also please explain the strategy for phasing out the old API(s) so > that we won't have three around forever. That is harder and I don't plan to do so. SendReceive2 and SendReceiveNoRsp is after this series no longer used by smb2, but they are still used by SMB1. SMB1 uses a LOT of different send/receive functions. I don't want to touch SMB1. I mostly want it to just go away :-) > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
