On Thu, Nov 02, 2017 at 03:14:26PM +0100, Aurélien Aptel wrote: > I know this is kind of unrelated but I've been thinking to myself we > should try to get rid of this dynamic allocation at some point. > > IIUC the iovec never has more than a couple of elements, so we could > have something like a fixed sized stack allocated iovec array + > MAX_IOVEC_LENGTH macro. > > Doing a kmalloc() for every packet defeats the purpose of the memory > pool optimization we use for small/large buffers. Yes. You probably just want everyone to allocate an additional entry in the vector for the header if needed, and just leave the slot empty and start processing at offset for cases like SMB direct. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
