My mistake. I misremembered the limit for XFS. Unless there are other issues in the reviews that will require a re-spin, maybe Steve can tweak the commit message. regards Ronnie Sahlberg On Wed, Sep 27, 2017 at 4:32 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Wed, Sep 27, 2017 at 04:20:01PM +1000, Ronnie Sahlberg wrote: >> The maximum is currently set to 64kb almost arbitrarily. 64kb is >> the maximum size of all xattrs under XFS so at least for >> samba + XFS (or EXT4) servers we will not be able to write so many >> EAs that we no longer can list them any more. > > This description looks confusing. > > For XFS the limits is 64kb for each individual xattr, not for all attrs. > > But your patch seems to be about the listxattr path anyway if I read > it correctly. There the VFS exposes a limit of XATTR_LIST_MAX, > which also happens to be 64kb for the buffer size that contains all > the xattr _names_. Note that XFS could support almost arbitrary large > amounts of xatttrs names (and on IRIX does), but on Linux we limit it > to this limit of the VFS listxattr interface. > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
