ok - renamed to SMBDEFAULT_VERSION (from SMB3DEFAULT_VERSION) and
repushed to cifs-2.6.git for-next (along with additional comment fix
from Pavel)
On Sun, Sep 17, 2017 at 3:27 PM, ronnie sahlberg
<ronniesahlberg@xxxxxxxxx> wrote:
> Reviewed-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
>
>
> Minor nit:
> + } else if (strcmp(tcon->ses->server->vals->version_string,
> + SMB3DEFAULT_VERSION_STRING) == 0) {
> + vneg_inbuf.Dialects[0] = cpu_to_le16(SMB21_PROT_ID);
> + vneg_inbuf.Dialects[1] = cpu_to_le16(SMB30_PROT_ID);
> + vneg_inbuf.Dialects[2] = cpu_to_le16(SMB302_PROT_ID);
>
> SMB3DEFAULT_VERSION has SMB3 in the name but also offers and supports smb2.1
> I have no suggestion on a better name though :-(
>
>
>
> On Mon, Sep 18, 2017 at 1:21 AM, Steve French <smfrench@xxxxxxxxx> wrote:
>> updated with more feedback
>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commitdiff;h=513f5b9040fdb0d1af887da9919be3fc07dcc236
>>
>> On Sat, Sep 16, 2017 at 4:00 PM, Steve French <smfrench@xxxxxxxxx> wrote:
>>> Updated with feedback from Pavel
>>>
>>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=shortlog;h=refs/heads/for-next
>>>
>>> On Fri, Sep 15, 2017 at 10:59 PM, Steve French <smfrench@xxxxxxxxx> wrote:
>>>> SMB2.1 or later dialect (instead of forcing only SMB3) for cifs.ko -
>>>> makes it easier if server is Windows 7 (last release dialect default
>>>> was upgraded from smb1/cifs to smb3 - but multidialect negotiation was
>>>> not supported until now)
>>>>
>>>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=0e0f8ad440ac117685aeed4df16f320c7e9ac1c6
>>>>
>>>> or see attached
>>>>
>>>>
>>>>
>>>> --
>>>> Thanks,
>>>>
>>>> Steve
>>>
>>>
>>>
>>> --
>>> Thanks,
>>>
>>> Steve
>>
>>
>>
>> --
>> Thanks,
>>
>> Steve
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
