> -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 2:07 PM > To: Long Li <longli@xxxxxxxxxxxxx>; Steve French <sfrench@xxxxxxxxx>; > linux-cifs@xxxxxxxxxxxxxxx; samba-technical@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: RE: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive > protocol > > > -----Original Message----- > > From: linux-cifs-owner@xxxxxxxxxxxxxxx [mailto:linux-cifs- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Long Li > > Sent: Wednesday, August 2, 2017 4:11 PM > > To: Steve French <sfrench@xxxxxxxxx>; linux-cifs@xxxxxxxxxxxxxxx; > > samba- technical@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > Cc: Long Li <longli@xxxxxxxxxxxxx> > > Subject: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive > > protocol > > > > SMBD uses a keep alive protocol to help peers detect if the remote is dead. > > When peer request keep alive, the transport needs to respond accordingly. > > The keepalive exchange is also used to replenish credits in certain > pathological conditions. > > > + // send an emtpy response right away if requested > > + if (le16_to_cpu(data_transfer->flags) | > > + le16_to_cpu(SMB_DIRECT_RESPONSE_REQUESTED)) { > > + info->keep_alive_requested = KEEP_ALIVE_PENDING; > > + } > > This is clearly a typo, the condition is always true. "&"?? Sorry it's a typo. > > Tom. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html