> -----Original Message----- > From: linux-cifs-owner@xxxxxxxxxxxxxxx [mailto:linux-cifs- > owner@xxxxxxxxxxxxxxx] On Behalf Of Long Li > Sent: Wednesday, August 2, 2017 4:10 PM > To: Steve French <sfrench@xxxxxxxxx>; linux-cifs@xxxxxxxxxxxxxxx; samba- > technical@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Cc: Long Li <longli@xxxxxxxxxxxxx> > Subject: [[PATCH v1] 14/37] [CIFS] SMBD: Post a SMBD data transfer message > with page payload > > /* > + * Send a page > + * page: the page to send > + * offset: offset in the page to send > + * size: length in the page to send > + * remaining_data_length: remaining data to send in this payload > + */ > +static int cifs_rdma_post_send_page(struct cifs_rdma_info *info, struct page > *page, > + unsigned long offset, size_t size, int remaining_data_length) > +{ >... > + wait_event(info->wait_send_queue, atomic_read(&info->send_credits) > > 0); This is an uninterruptible wait, correct? What's to guarantee the event will ever fire? Also, if the count is zero, there should be a check that an SMB Direct credit request is outstanding. If not, it's wasteful to sleep for the keepalive timer to do so. Tom. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
