> +/* > + * Per RDMA transport connection parameters > + * as defined in [MS-SMBD] 3.1.1.1 > + */ > +static int receive_credit_max = 512; > +static int send_credit_target = 512; > +static int max_send_size = 8192; > +static int max_fragmented_recv_size = 1024*1024; > +static int max_receive_size = 8192; Are these protocol constants? If so please use either #defines or enums with upper case names for them. > +// maximum number of SGEs in a RDMA I/O Please always use /* ... */ style comments in the kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html